Change in osmo-gsm-tester[master]: Introduce support for AmarisoftEPC

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

srs_andre gerrit-no-reply at lists.osmocom.org
Wed Apr 1 08:53:47 UTC 2020


srs_andre has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17690 )

Change subject: Introduce support for AmarisoftEPC
......................................................................


Patch Set 1: Code-Review+1

(4 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17690/1/example/defaults.conf 
File example/defaults.conf:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17690/1/example/defaults.conf@101 
PS1, Line 101:   rlc_drb_mode: UM
I think this should be renamed to qci or default_bearer_qci and put up under epc, it's common to srsepc and amarisoft epc


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17690/1/example/defaults.conf@105 
PS1, Line 105:   license_server_addr: 10.12.1.139
see discussion around Amarisoft ENB and license server option, I guess it should be "" by default


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17690/1/src/osmo_gsm_tester/amarisoft_epc.py 
File src/osmo_gsm_tester/amarisoft_epc.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17690/1/src/osmo_gsm_tester/amarisoft_epc.py@26 
PS1, Line 26: #def rlc_drb_mode2qci(rlc_drb_mode):
remove this lookup, user should provide the qci value in config, by default 9 can be used


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17690/1/src/osmo_gsm_tester/amarisoft_epc.py@152 
PS1, Line 152:         #rlc_drb_mode = values['epc'].get('rlc_drb_mode', None)
remove



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17690
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ia50ea6a74b63b2d688c8d683aea11416ad40a6d3
Gerrit-Change-Number: 17690
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: srs_andre <andre at softwareradiosystems.com>
Gerrit-Comment-Date: Wed, 01 Apr 2020 08:53:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200401/c2f56c81/attachment.htm>


More information about the gerrit-log mailing list