Change in ...osmo-pcu[master]: Log RACH Requests using GSMTAP

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Sep 30 18:05:47 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15632 )

Change subject: Log RACH Requests using GSMTAP
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/15632/1/src/bts.h 
File src/bts.h:

https://gerrit.osmocom.org/#/c/15632/1/src/bts.h@67 
PS1, Line 67: blocks
bursts


https://gerrit.osmocom.org/#/c/15632/1/src/bts.cpp 
File src/bts.cpp:

https://gerrit.osmocom.org/#/c/15632/1/src/bts.cpp@753 
PS1, Line 753: sizeof(ra)
sizeof(uint16_t) is always 2, while we should pass 1 for 8-bit RA and 2 for 11-bit RA.


https://gerrit.osmocom.org/#/c/15632/1/src/pcu_vty.c 
File src/pcu_vty.c:

https://gerrit.osmocom.org/#/c/15632/1/src/pcu_vty.c@55 
PS1, Line 55: Blocks
Bursts, RACH has no blocks.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15632
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ib686a49e8c630808c30bede5810cd65fc045954a
Gerrit-Change-Number: 15632
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 30 Sep 2019 18:05:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190930/973784e6/attachment.htm>


More information about the gerrit-log mailing list