Change in ...osmo-pcu[master]: Log AGCH and PCH blocks using GSMTAP

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Sep 30 18:01:13 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15633 )

Change subject: Log AGCH and PCH blocks using GSMTAP
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/15633/1/src/bts.h 
File src/bts.h:

https://gerrit.osmocom.org/#/c/15633/1/src/bts.h@61 
PS1, Line 61: PTCCH
copy-paste, please fix


https://gerrit.osmocom.org/#/c/15633/1/src/bts.h@62 
PS1, Line 62: PTCCH
copy-paste, please fix


https://gerrit.osmocom.org/#/c/15633/1/src/pcu_l1_if.cpp 
File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/#/c/15633/1/src/pcu_l1_if.cpp@241 
PS1, Line 241: data, 23+3
We need to send a MAC block to Wireshark without the prefix, so:

  ..., data + 4, 23);



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15633
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I4d62f98801af1b0a290d3dd35bd213ccf3151035
Gerrit-Change-Number: 15633
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 30 Sep 2019 18:01:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190930/62ade934/attachment.htm>


More information about the gerrit-log mailing list