Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: TC_cs_lqual_ul_tbf: properly check for Dynamic As...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sun Sep 29 12:48:46 UTC 2019


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15620


Change subject: PCU_Tests_RAW.ttcn: TC_cs_lqual_ul_tbf: properly check for Dynamic Assignment
......................................................................

PCU_Tests_RAW.ttcn: TC_cs_lqual_ul_tbf: properly check for Dynamic Assignment

Change-Id: I05cf0c62d21094fb53a9e5e54b404f3cf972a182
---
M pcu/PCU_Tests_RAW.ttcn
1 file changed, 6 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/15620/1

diff --git a/pcu/PCU_Tests_RAW.ttcn b/pcu/PCU_Tests_RAW.ttcn
index 15a9cf6..a12b198 100644
--- a/pcu/PCU_Tests_RAW.ttcn
+++ b/pcu/PCU_Tests_RAW.ttcn
@@ -631,7 +631,6 @@
 	}
 
 	/* Make sure we received an UL TBF Assignment */
-	/* TODO: check if we got single or dynamic assignment */
 	if (match(rr_msg, tr_IMM_TBF_ASS(dl := false, rest := tr_IaRestOctets_ULAss(?)))) {
 		ul_tbf_ass := rr_msg.payload.imm_ass.rest_octets.hh.pa.uldl.ass.ul;
 		log("Rx Uplink TBF assignment: ", ul_tbf_ass);
@@ -641,6 +640,12 @@
 		mtc.stop;
 	}
 
+	/* Make sure we have got a Dynamic Assignment */
+	if (ischosen(ul_tbf_ass.single)) {
+		setverdict(fail, "Single block Assignment is not handled by ", testcasename());
+		mtc.stop;
+	}
+
 	var template (value) RlcmacUlBlock ul_data := t_RLCMAC_UL_DATA(
 		tfi := ul_tbf_ass.dynamic.tfi_assignment,
 		cv := 15, /* 15 UL blocks to be sent (to be overridden in loop) */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15620
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I05cf0c62d21094fb53a9e5e54b404f3cf972a182
Gerrit-Change-Number: 15620
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190929/80b147d4/attachment.htm>


More information about the gerrit-log mailing list