Change in ...libosmocore[master]: gsm29205_test: fix error: missing braces around initializer

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Sep 27 03:16:20 UTC 2019


fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/15595 )

Change subject: gsm29205_test: fix error: missing braces around initializer
......................................................................

gsm29205_test: fix error: missing braces around initializer

Since structure 'osmo_gcr_parsed' does contain arrays, GCC is not
happy about the way we initialize it. Let's do it explicitly.

Change-Id: Ia814b4a4ed5bec84ff1f69232f7f7d5ca0d19794
---
M tests/gsm29205/gsm29205_test.c
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/gsm29205/gsm29205_test.c b/tests/gsm29205/gsm29205_test.c
index 5add1b1..44c3453 100644
--- a/tests/gsm29205/gsm29205_test.c
+++ b/tests/gsm29205/gsm29205_test.c
@@ -44,7 +44,13 @@
 	};
 	uint8_t len;
 	struct msgb *msg;
-	struct osmo_gcr_parsed p = { 0 }, g = {
+	struct osmo_gcr_parsed p = {
+		.net_len = 0,
+		.net = { 0 },
+		.node = 0x00,
+		.cr = { 0 },
+	};
+	struct osmo_gcr_parsed g = {
 		.net_len = 3,
 		.net = { 0x51, 0x52, 0x53 },
 		.node = 0xDEAD,

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15595
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia814b4a4ed5bec84ff1f69232f7f7d5ca0d19794
Gerrit-Change-Number: 15595
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190927/b4354f73/attachment.htm>


More information about the gerrit-log mailing list