Change in ...osmo-ttcn3-hacks[master]: Cosmetic: Fix comment

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Sep 26 19:24:16 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15596 )

Change subject: Cosmetic: Fix comment
......................................................................

Cosmetic: Fix comment

Change-Id: Ie1c80d951ea2f8e3e154beb5623aa0d5f5874a60
---
M msc/MSC_Tests.ttcn
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 7499456..7c4ac51 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -4858,9 +4858,9 @@
 	/* Even on a failed paging the SGs Association should stay intact */
 	f_ctrl_get_exp(IPA_CTRL, "fsm.SGs-UE.id.imsi:" & hex2str(g_pars.imsi) & ".state", "SGs-ASSOCIATED");
 
-	/* Note: We do not execute f_sgsap_bssmap_screening() here since the
-	 * MSC/VLR would re-try to deliver the test SMS trigered above and
-	 * so the screening would fail. */
+	/* Make sure that the SMS we just inserted is cleared and the
+	 * subscriber is expired. This is necessary because otherwise the MSC
+	 * might re-try the SMS delivery and disturb the following tests. */
 
 	f_vty_sms_clear(hex2str(g_pars.imsi));
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15596
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie1c80d951ea2f8e3e154beb5623aa0d5f5874a60
Gerrit-Change-Number: 15596
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190926/ebf20bb1/attachment.htm>


More information about the gerrit-log mailing list