Change in ...osmo-msc[master]: sgs_iface: Accept messages with unknown TLV elements

[laforge]

laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/15599 )

Change subject: sgs_iface: Accept messages with unknown TLV elements
......................................................................

sgs_iface: Accept messages with unknown TLV elements

3GPP TS 29.118, chapter 7.5 states that unknown TLV elements should be
ignored rather than that the whole message is discarded a STATUS message
is sent. Lets turn the returncode check of the tlv_parse() call into a
log message and continue normally.

Change-Id: Ic6714451ad970043d4765f8420d753daf5294a44
Related: OS#4214
---
M src/libmsc/sgs_iface.c
1 file changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

Objections:
  fixeria: I would prefer this is not merged as is



diff --git a/src/libmsc/sgs_iface.c b/src/libmsc/sgs_iface.c
index b12991c..a4527f4 100644
--- a/src/libmsc/sgs_iface.c
+++ b/src/libmsc/sgs_iface.c
@@ -945,10 +945,8 @@
 
 	/* Parse TLV elements */
 	rc = tlv_parse(&tp, &sgsap_ie_tlvdef, msgb_l2(msg) + 1, msgb_l2len(msg) - 1, 0, 0);
-	if (rc < 0) {
-		TX_STATUS_AND_LOG(sgc, msg_type, SGSAP_SGS_CAUSE_SEMANT_INCORR_MSG, "SGsAP Message %s parsing error\n");
-		goto error;
-	}
+	if (rc < 0)
+		LOGSGC(sgc, LOGL_NOTICE, "SGsAP Message %s contains unknown TLV IEs\n", sgsap_msg_type_name(msg_type));
 
 	/* Most of the messages contain an IMSI as mandatory IE, parse it right here */
 	if (!TLVP_PRESENT(&tp, SGSAP_IE_IMSI) &&

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15599
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ic6714451ad970043d4765f8420d753daf5294a44
Gerrit-Change-Number: 15599
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190926/e397fea3/attachment.htm>