Change in ...libosmocore[master]: msgb: Allow size==headroom in msgb_alloc_headroom*()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Sep 26 15:52:50 UTC 2019


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15607


Change subject: msgb: Allow size==headroom in msgb_alloc_headroom*()
......................................................................

msgb: Allow size==headroom in msgb_alloc_headroom*()

Nothinh really forbids this case, it's totally fine allocating all space
of msgb as headroom. osmo-pcu actually does that in
gprs_rlcmac_ul_tbf::snd_ul_ud().

Related: OS#4029
Change-Id: Ibe05d08e3169a2603e891f76682a3b352a93ec7a
---
M include/osmocom/core/msgb.h
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/07/15607/1

diff --git a/include/osmocom/core/msgb.h b/include/osmocom/core/msgb.h
index e05d37f..1833a6c 100644
--- a/include/osmocom/core/msgb.h
+++ b/include/osmocom/core/msgb.h
@@ -518,7 +518,7 @@
 static inline struct msgb *msgb_alloc_headroom_c(const void *ctx, int size, int headroom,
 						 const char *name)
 {
-	osmo_static_assert(size > headroom, headroom_bigger);
+	osmo_static_assert(size >= headroom, headroom_bigger);
 
 	struct msgb *msg = msgb_alloc_c(ctx, size, name);
 	if (msg)
@@ -540,7 +540,7 @@
 static inline struct msgb *msgb_alloc_headroom(int size, int headroom,
 						const char *name)
 {
-	osmo_static_assert(size > headroom, headroom_bigger);
+	osmo_static_assert(size >= headroom, headroom_bigger);
 
 	struct msgb *msg = msgb_alloc(size, name);
 	if (msg)

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15607
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe05d08e3169a2603e891f76682a3b352a93ec7a
Gerrit-Change-Number: 15607
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190926/d2da41f8/attachment.htm>


More information about the gerrit-log mailing list