Change in ...osmo-trx[master]: Transceiver: Fixed copying of history into and from channelizer buffer.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Sep 20 17:29:04 UTC 2019


pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/15413 )

Change subject: Transceiver: Fixed copying of history into and from channelizer buffer.
......................................................................

Transceiver: Fixed copying of history into and from channelizer buffer.

In multi arfcn mode, osmo-trx would drop some bursts because it couldn't detect it
and would emit idle burst instead. Specificaly detection of peak in correlation
vector failed. Correcting copying of history in pullBuffer method fixes this issue.

[Re-worked by Pau Espin Pedrol <pespin at sysmocom.de>]

Fixes: 57df2362f0eca0a330aad3e18906046dfadb9c8b
Change-Id: I93e43f6868cd67e69fc59d2980a03550d2505bf8
---
M Transceiver52M/radioInterfaceMulti.cpp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/Transceiver52M/radioInterfaceMulti.cpp b/Transceiver52M/radioInterfaceMulti.cpp
index 99f6231..eec426e 100644
--- a/Transceiver52M/radioInterfaceMulti.cpp
+++ b/Transceiver52M/radioInterfaceMulti.cpp
@@ -288,7 +288,7 @@
 		complex *dst = history[lchan]->begin();
 		float *fsrc = &buf[2 * (cLen - hLen)];
 		for (i = 0; i < hLen; i++) {
-			*dst = complex(fdst[0], fdst[1]);
+			*dst = complex(fsrc[0], fsrc[1]);
 			fsrc += 2;
 			dst++;
 		}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15413
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I93e43f6868cd67e69fc59d2980a03550d2505bf8
Gerrit-Change-Number: 15413
Gerrit-PatchSet: 3
Gerrit-Owner: timojacobus <timojacobus5 at gmail.com>
Gerrit-Assignee: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: timojacobus <timojacobus5 at gmail.com>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190920/e54e168f/attachment.htm>


More information about the gerrit-log mailing list