Change in ...osmo-ttcn3-hacks[master]: library/PCUIF_CodecPort.ttcn: strip padding bytes from PCUIF_data

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Sep 20 15:26:07 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15571 )

Change subject: library/PCUIF_CodecPort.ttcn: strip padding bytes from PCUIF_data
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/15571/1/library/PCUIF_CodecPort.ttcn 
File library/PCUIF_CodecPort.ttcn:

https://gerrit.osmocom.org/#/c/15571/1/library/PCUIF_CodecPort.ttcn@32 
PS1, Line 32: for (var integer i := 0; i < data.len; i := i + 1) {
            : 		res[i] := data.data[i];
            : 	}
there is a builtin substring function called 'substr' which we use in various places of osmo-ttcn3-hacks already.  So please replace the above with "res := substr(data.data, 0, data.len)"



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15571
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibd698094c897d395208e80189457444a91018beb
Gerrit-Change-Number: 15571
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Sep 2019 15:26:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190920/3a1c0acd/attachment.htm>


More information about the gerrit-log mailing list