Change in ...libosmocore[master]: ecu_fr: increase test coverage for FR ECU implementation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Fri Sep 20 10:06:46 UTC 2019


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15574 )

Change subject: ecu_fr: increase test coverage for FR ECU implementation
......................................................................


Patch Set 4:

(1 comment)

I was not aware that any application was using the direct API to the FR-ECU. I just thought that those function prototypes were only there to keep the unit-test code. I have now mared the API as OSMO_DEPRECATED and increased the test coverage a bit so that the generic ECU abstraction and the old direct function calls are tested equally.

https://gerrit.osmocom.org/#/c/15574/3/include/osmocom/codec/ecu.h 
File include/osmocom/codec/ecu.h:

https://gerrit.osmocom.org/#/c/15574/3/include/osmocom/codec/ecu.h@a14 
PS3, Line 14: 
> Use OSMO_DEPRECATED() for that.
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15574
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib0c8a9b164f14ea4fa00688f760a76cdb4890af4
Gerrit-Change-Number: 15574
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Sep 2019 10:06:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190920/4a94f3de/attachment.htm>


More information about the gerrit-log mailing list