Change in ...osmo-ttcn3-hacks[master]: Introduce PCUIF, BTS and ClckGen components for RAW PCU test cases

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Sep 19 10:12:22 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15430 )

Change subject: Introduce PCUIF, BTS and ClckGen components for RAW PCU test cases
......................................................................


Patch Set 8:

(3 comments)

https://gerrit.osmocom.org/#/c/15430/8//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/#/c/15430/8//COMMIT_MSG@42 
PS8, Line 42:   +-----+               +----------+      +---------+
May make sense moving this to the tests .ttcn file to have it always available easily.


https://gerrit.osmocom.org/#/c/15430/8/pcu/PCUIF_RAW_Components.ttcn 
File pcu/PCUIF_RAW_Components.ttcn:

https://gerrit.osmocom.org/#/c/15430/8/pcu/PCUIF_RAW_Components.ttcn@182 
PS8, Line 182: 		MTC.send(RAW_PCU_EVENT:PCU_EV_CONNECT);
Should we be sending message to either MTC or BTS, but not both at the same time? and then test defines where it wants it to be sent (eg by registering a BTS).


https://gerrit.osmocom.org/#/c/15430/8/pcu/PCU_Tests_RAW.ttcn 
File pcu/PCU_Tests_RAW.ttcn:

https://gerrit.osmocom.org/#/c/15430/8/pcu/PCU_Tests_RAW.ttcn@472 
PS8, Line 472: 	connect(vc_PCUIF:MTC, self:PCUIF);
Are you sure you need to connect A->B and B->A two times?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15430
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I63a23abebab88fd5318eb4d907d6028e7c38e9a3
Gerrit-Change-Number: 15430
Gerrit-PatchSet: 8
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 19 Sep 2019 10:12:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190919/41892683/attachment.htm>


More information about the gerrit-log mailing list