This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15430 )
Change subject: Introduce PCUIF, BTS and ClckGen components for RAW PCU test cases
......................................................................
Patch Set 8: Code-Review+1
(3 comments)
https://gerrit.osmocom.org/#/c/15430/8/pcu/PCUIF_RAW_Components.ttcn
File pcu/PCUIF_RAW_Components.ttcn:
https://gerrit.osmocom.org/#/c/15430/8/pcu/PCUIF_RAW_Components.ttcn@33
PS8, Line 33: Genetic
"Generic"? ;)
https://gerrit.osmocom.org/#/c/15430/8/pcu/PCUIF_RAW_Components.ttcn@85
PS8, Line 85: // port RAW_PCU_MSG_PT CCCH; /* SAPI: PCU_IF_SAPI_{BCCH,PCH,RACH,AGCH} */
These commented out ports look like leftovers. Are they still userful?
EDIT: ah, you intend to use it later as indicated by "TODO: implement message (de)muxing by SAPI" below
https://gerrit.osmocom.org/#/c/15430/8/pcu/PCUIF_RAW_Components.ttcn@136
PS8, Line 136: if (pcu_msg.bts_nr != bts_nr) {
Why can't we always set the correct bts nr in the test case sending the pcu_msg?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15430
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I63a23abebab88fd5318eb4d907d6028e7c38e9a3
Gerrit-Change-Number: 15430
Gerrit-PatchSet: 8
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 19 Sep 2019 08:19:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190919/19979389/attachment.htm>