This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/15519 ) Change subject: radioInterface: Remove unusued getRxGain() ...................................................................... radioInterface: Remove unusued getRxGain() Only the radioDevice->getRxGain() is called from inside radioInterfaceMulti, so the API in radioInterface is not used at all. Change-Id: Icc4e9a7ebfdafe7c72c535752a5e379d12592c9a --- M Transceiver52M/radioInterface.cpp M Transceiver52M/radioInterface.h 2 files changed, 0 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve daniel: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/Transceiver52M/radioInterface.cpp b/Transceiver52M/radioInterface.cpp index bd19b24..9c7c044 100644 --- a/Transceiver52M/radioInterface.cpp +++ b/Transceiver52M/radioInterface.cpp @@ -307,11 +307,6 @@ return mDevice->setRxGain(dB, chan); } -double RadioInterface::getRxGain(size_t chan) -{ - return mDevice->getRxGain(chan); -} - /* Receive a timestamped chunk from the device */ int RadioInterface::pullBuffer() { diff --git a/Transceiver52M/radioInterface.h b/Transceiver52M/radioInterface.h index 235d888..945624a 100644 --- a/Transceiver52M/radioInterface.h +++ b/Transceiver52M/radioInterface.h @@ -109,9 +109,6 @@ /** set receive gain */ double setRxGain(double dB, size_t chan = 0); - /** get receive gain */ - double getRxGain(size_t chan = 0); - /** drive transmission of GSM bursts */ void driveTransmitRadio(std::vector<signalVector *> &bursts, std::vector<bool> &zeros); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Icc4e9a7ebfdafe7c72c535752a5e379d12592c9a Gerrit-Change-Number: 15519 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190918/1967bf3b/attachment.htm>