Change in ...osmo-trx[master]: radioInterfaceMulti: Override setTxGain() to avoid chan!=0 calls

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Sep 18 13:59:37 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15521 )

Change subject: radioInterfaceMulti: Override setTxGain() to avoid chan!=0 calls
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> I don't know how the inheritance looks like, but aren't you actually adding the setTxGain() method to both RadioInterface and *Multi?
> 
> So you're overriding the RadioDevice setTxGain method in RadioInterface(Multi)?

radioInterface class is the base and usual radio interface class (and it's not abstract, it's instantiable since it's the "simple usual" one). Then, there are 2 child class extending and overriding some parts of the radioInterface base class:
-radioInterfaceResamp
-radioInterfaceMult

radioInterface{,Resamp,Mult} interact with its mDevice (radioDevice), which is an abstract class extended by LMSDevice, UHDDevice, USRPDevice.

In this commit I'm overriding radioInterface::setTxGain() in radioInterfaceMult to avoid calling radioDevice::setTxGain() on chans != 0 since it doesn't make sense to do so, because radioInterfaceMult is used when logical channels are multiplexed in one SDR physical channel, so in that scenario the radioDevice is going to be expecting to manage 1 physical channel.

This way we simplify the logic of each radioDevice implementation and keep it as much as possible inside radioInterfaceMult, responsible of muxing the multiple channels into one.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15521
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I7e67f660c3b0b009db59b405de603f6058021802
Gerrit-Change-Number: 15521
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Sep 2019 13:59:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190918/31889c6a/attachment.htm>


More information about the gerrit-log mailing list