This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15489 ) Change subject: osmo-bts-trx/scheduler: fix: check rc of osmo_ecu_frame_out() ...................................................................... osmo-bts-trx/scheduler: fix: check rc of osmo_ecu_frame_out() Change-Id: I32d244f5ddef46c8b8719f5ec27b7456514d407a Fixes: CID#204005 (CID#204007), CID#204006 (CID#204004) --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index 45fc701..8b0c761 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -1272,7 +1272,8 @@ /* If there is an ECU active on this channel, use its output */ if (lchan->ecu_state) { rc = osmo_ecu_frame_out(lchan->ecu_state, tch_data); - goto compose_l1sap; + if (rc >= 0) /* Otherwise we send a BFI */ + goto compose_l1sap; } switch (tch_mode) { @@ -1485,7 +1486,8 @@ /* If there is an ECU active on this channel, use its output */ if (lchan->ecu_state) { rc = osmo_ecu_frame_out(lchan->ecu_state, tch_data); - goto compose_l1sap; + if (rc >= 0) /* Otherwise we send a BFI */ + goto compose_l1sap; } switch (tch_mode) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15489 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I32d244f5ddef46c8b8719f5ec27b7456514d407a Gerrit-Change-Number: 15489 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190918/e4a83d2d/attachment.htm>