Change in ...osmo-bts[master]: vty: add "logging filter l1-sapi"

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Wed Sep 18 07:48:36 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15550 )

Change subject: vty: add "logging filter l1-sapi"
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/15550/1/src/common/vty.c 
File src/common/vty.c:

https://gerrit.osmocom.org/#/c/15550/1/src/common/vty.c@1607 
PS1, Line 1607: uint16_t parse_l1_sapi_str(const char *sapi) {
> there is a sapi_string[] in pcu_sock.c ... it is uppercase though. […]
Done


https://gerrit.osmocom.org/#/c/15550/1/src/common/vty.c@1640 
PS1, Line 1640: 		*sapi_mask = talloc(tgt, uint16_t);
> initially I was sure that this was a memleak; instead: kudos for getting this right.
yay, thanks :D



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15550
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I32d86d3d34757135b4cce59919c2fc2b67f0a889
Gerrit-Change-Number: 15550
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Sep 2019 07:48:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190918/2a88e2c5/attachment.htm>


More information about the gerrit-log mailing list