This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 ) Change subject: log: set L1 SAPI context ...................................................................... Patch Set 3: Code-Review-1 (2 comments) This change is ready for review. https://gerrit.osmocom.org/#/c/15539/3/src/common/logging.c File src/common/logging.c: https://gerrit.osmocom.org/#/c/15539/3/src/common/logging.c@148 PS3, Line 148: static int filter_fn(const struct log_context *ctx, struct log_target *tgt) (personally would prefer "osmo_bts_filter_fn()" to not overload other generally named filter_fn()s for easier grepping) https://gerrit.osmocom.org/#/c/15539/3/src/common/logging.c@158 PS3, Line 158: return 1; > In OsmoBSC, and even in a libosmocore test, the return values are inverted... […] Looking at osmo_bsc_main.c filter_fn(), it seems that the intention is this: "Normally", we set 'logging set filter all 1' to see all logging, so should_log_to_target() exits with true before even asking filter_fn()s. But in case of 'filter all 0', then everything is considered switched off. >From this baseline, specific filters can explicitly enable logging to "re-appear": If no filter is set, then you should return 0 -- it remains off. If a filter is set and it matches, return 1: if ((tgt->filter_map & (1 << LOG_FLT_L1_SAPI)) != 0 && sapi_mask && sapi && (*sapi_mask & (1 << *sapi)) != 0) return 1; return 0; Again, compare osmo_bsc_main.c filter_fn(). <Insert rant here that the current filter stuff is insanely hard to get right on so many levels> -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6b7bb2e1d61502b61214f854a4ec5cbb7267545b Gerrit-Change-Number: 15539 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Wed, 18 Sep 2019 01:18:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190918/89a2db08/attachment.htm>