Change in ...osmo-ttcn3-hacks[master]: MGCP: fix pattern warning

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Wed Sep 18 00:45:35 UTC 2019


neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/12237 )

Change subject: MGCP: fix pattern warning
......................................................................

MGCP: fix pattern warning

Remove implied \r to fix following warnings:
"Duplicate character `\r' in the character set. Please note the \n
includes the \r implicitly. Use \q{0,0,0,10} if you would like to match
the LF only."

Change-Id: I99948e4b82b5b4bd5b8f7c1a4c60a97fcab3c0eb
---
M library/MGCP_Types.ttcn
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  neels: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/library/MGCP_Types.ttcn b/library/MGCP_Types.ttcn
index b56734c..6febc51 100644
--- a/library/MGCP_Types.ttcn
+++ b/library/MGCP_Types.ttcn
@@ -54,7 +54,7 @@
 		MgcpVersion	ver
 	} with {
 		variant "SEPARATOR(' ', '[\t ]+')"
-		variant "END('\r\n', '([\r\n])|(\r\n)')"
+		variant "END('\n', '([\n])|(\n)')"
 	}
 
 	type record MgcpParameter {
@@ -63,7 +63,7 @@
 	} with {
 		variant "BEGIN('')"
 		variant "SEPARATOR(': ', ':[\t ]+')"
-		variant "END('\r\n', '([\r\n])|(\r\n)')"
+		variant "END('\n', '([\n])|(\n)')"
 	}
 
 	type set of MgcpParameter MgcpParameterList with {
@@ -76,7 +76,7 @@
 		SDP_Message		sdp optional
 	} with {
 		variant "BEGIN('')"
-		variant (sdp) "BEGIN('\r\n','([\r\n])|(\r\n)')"
+		variant (sdp) "BEGIN('\n','([\n])|(\n)')"
 	}
 
 	external function enc_MgcpCommand(in MgcpCommand id) return charstring
@@ -90,7 +90,7 @@
 		charstring		string optional
 	} with {
 		variant "SEPARATOR(' ', '[\t ]+')"
-		variant "END('\r\n', '([\r\n])|(\r\n)')"
+		variant "END('\n', '([\n])|(\n)')"
 	}
 
 	type record MgcpResponse {
@@ -99,7 +99,7 @@
 		SDP_Message		sdp optional
 	} with {
 		variant "BEGIN('')"
-		variant (sdp) "BEGIN('\r\n','([\r\n])|(\r\n)')"
+		variant (sdp) "BEGIN('\n','([\n])|(\n)')"
 	}
 
 	external function enc_MgcpResponse(in MgcpResponse id) return charstring

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/12237
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I99948e4b82b5b4bd5b8f7c1a4c60a97fcab3c0eb
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 4
Gerrit-Owner: Max <suraev at alumni.ntnu.no>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <suraev at alumni.ntnu.no>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190918/3229dd8a/attachment.htm>


More information about the gerrit-log mailing list