Change in ...osmo-sgsn[master]: gprs_ranap: introduce Iu helper to free the UE context

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Tue Sep 17 23:55:07 UTC 2019


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15481 )

Change subject: gprs_ranap: introduce Iu helper to free the UE context
......................................................................


Patch Set 6: Code-Review-1

Atomic patches are good, but IMHO this one is sub-atomic:
it is hard to tell whether these functions are well designed when there are no callers.
Please don't add dead code, i.e. squash this patch into the other patch that actually calls these functions?


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15481
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Id1c1d453cf91f566a01ef9480ffffff3850a1031
Gerrit-Change-Number: 15481
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Sep 2019 23:55:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190917/951c787b/attachment.htm>


More information about the gerrit-log mailing list