This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
lynxis lazus gerrit-no-reply at lists.osmocom.orglynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15481 )
Change subject: gprs_ranap: introduce Iu helper to free the UE context
......................................................................
Patch Set 6:
(1 comment)
https://gerrit.osmocom.org/#/c/15481/6/include/osmocom/sgsn/gprs_ranap.h
File include/osmocom/sgsn/gprs_ranap.h:
https://gerrit.osmocom.org/#/c/15481/6/include/osmocom/sgsn/gprs_ranap.h@25
PS6, Line 25: inline static void sgsn_ranap_iu_free(void *ctx) {};
> Why do you need this? the code calling this functions should be always inside BUILD_IU afaiu.
i like it this way to define them as no-op instead of using a ifdef multiple times.
E.g. when using it in gprs_mm_state_iu_fsm.h I would need to add ifdef BUILD_IU around it.
Same in gmm_attach.c if we release the Iu connection of RAU where we don't have any context
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15481
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Id1c1d453cf91f566a01ef9480ffffff3850a1031
Gerrit-Change-Number: 15481
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Sep 2019 23:05:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190917/b3681b8a/attachment.htm>