Change in ...osmo-trx[master]: radioInterfaceMulti: Check equals zero explicitly

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Sep 13 17:29:33 UTC 2019


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15515


Change subject: radioInterfaceMulti: Check equals zero explicitly
......................................................................

radioInterfaceMulti: Check equals zero explicitly

It's not a pointer check or a boolean expression, in here we really
check chan index is 0, so it's more clear doing so this way like it's
done in all other places.

Change-Id: I83b14487d14ba8272f58796f640f58a88891e532
---
M Transceiver52M/radioInterfaceMulti.cpp
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/15/15515/1

diff --git a/Transceiver52M/radioInterfaceMulti.cpp b/Transceiver52M/radioInterfaceMulti.cpp
index 7c1ee74..c41ec22 100644
--- a/Transceiver52M/radioInterfaceMulti.cpp
+++ b/Transceiver52M/radioInterfaceMulti.cpp
@@ -400,7 +400,7 @@
 
 double RadioInterfaceMulti::setRxGain(double db, size_t chan)
 {
-  if (!chan)
+  if (chan == 0)
     return mDevice->setRxGain(db);
   else
     return mDevice->getRxGain();

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15515
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I83b14487d14ba8272f58796f640f58a88891e532
Gerrit-Change-Number: 15515
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190913/5f8964f1/attachment.htm>


More information about the gerrit-log mailing list