Change in ...pysim[master]: pySim-prog: use functions to derive MCC/MNC from IMSI

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Sep 12 12:59:23 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/15497 )

Change subject: pySim-prog: use functions to derive MCC/MNC from IMSI
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/15497/1/pySim/utils.py 
File pySim/utils.py:

https://gerrit.osmocom.org/#/c/15497/1/pySim/utils.py@226 
PS1, Line 226: 	if imsi == None:
             : 		return None
             : 
             :         if len(imsi) > 3:
             :                 if 
there's a mixture of spaces and tabs, which may not be the best idea if working with python.  The existing code seems to use tabs more or less everywhere, while the new code here uses spaces.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/15497
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I98e5bf8f9ff2a852efb190cc789edf42c5075bf8
Gerrit-Change-Number: 15497
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Thu, 12 Sep 2019 12:59:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190912/28ffd0db/attachment.htm>


More information about the gerrit-log mailing list