Change in ...pysim[master]: cards: use string representation for MNC/MCC

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Thu Sep 12 12:40:34 UTC 2019


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/15496 )

Change subject: cards: use string representation for MNC/MCC
......................................................................


Patch Set 1: Code-Review-1

Don't you need to modify enc_plmn for that as well?

pySim/utils.py line 101:
swap_nibbles(lpad('%d' % mcc, 3) + lpad('%d' % mnc, 3))


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/15496
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia2333921a4863f0f26ee923ca796e62ec5e2d59a
Gerrit-Change-Number: 15496
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Thu, 12 Sep 2019 12:40:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190912/d24924ef/attachment.htm>


More information about the gerrit-log mailing list