Change in ...osmo-sgsn[master]: gprs_mm_state_gb_fsm: ensure T3350 is not running when entering IDLE

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Sep 12 11:16:22 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15486 )

Change subject: gprs_mm_state_gb_fsm: ensure T3350 is not running when entering IDLE
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/15486/2/src/sgsn/gprs_mm_state_gb_fsm.c 
File src/sgsn/gprs_mm_state_gb_fsm.c:

https://gerrit.osmocom.org/#/c/15486/2/src/sgsn/gprs_mm_state_gb_fsm.c@24 
PS2, Line 24: 	if (ctx->T == 3350 && osmo_timer_pending(&ctx->timer))
When is this timer set? in both MM_STANDBLY and READY? we should probably move it to osmo_tdef in this FSM so it is disabled automatically?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15486
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ibdd913173af11d0e6d04aa392e047d5d9aee1243
Gerrit-Change-Number: 15486
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 12 Sep 2019 11:16:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190912/820b49c8/attachment.htm>


More information about the gerrit-log mailing list