Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: fix: check rc of osmo_ecu_frame_out()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Sep 12 00:45:10 UTC 2019


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15489


Change subject: osmo-bts-trx/scheduler: fix: check rc of osmo_ecu_frame_out()
......................................................................

osmo-bts-trx/scheduler: fix: check rc of osmo_ecu_frame_out()

Change-Id: I32d244f5ddef46c8b8719f5ec27b7456514d407a
Fixes: CID#204005 (CID#204007), CID#204006 (CID#204004)
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 10 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/89/15489/1

diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c
index 45fc701..6107d2f 100644
--- a/src/osmo-bts-trx/scheduler_trx.c
+++ b/src/osmo-bts-trx/scheduler_trx.c
@@ -1272,6 +1272,11 @@
 			/* If there is an ECU active on this channel, use its output */
 			if (lchan->ecu_state) {
 				rc = osmo_ecu_frame_out(lchan->ecu_state, tch_data);
+				if (rc < 0) {
+					LOGL1S(DL1P, LOGL_ERROR, l1t, bi->tn, chan, bi->fn,
+					       "ECU failed to encode a frame (rc=%d)\n", rc);
+					return rc;
+				}
 				goto compose_l1sap;
 			}
 
@@ -1485,6 +1490,11 @@
 			/* If there is an ECU active on this channel, use its output */
 			if (lchan->ecu_state) {
 				rc = osmo_ecu_frame_out(lchan->ecu_state, tch_data);
+				if (rc < 0) {
+					LOGL1S(DL1P, LOGL_ERROR, l1t, bi->tn, chan, bi->fn,
+					       "ECU failed to encode a frame (rc=%d)\n", rc);
+					return rc;
+				}
 				goto compose_l1sap;
 			}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15489
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I32d244f5ddef46c8b8719f5ec27b7456514d407a
Gerrit-Change-Number: 15489
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190912/a6dec350/attachment.htm>


More information about the gerrit-log mailing list