Change in ...osmo-pcu[master]: Forward ETWS Primary Notification to MS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Wed Sep 11 12:43:39 UTC 2019


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15459 )

Change subject: Forward ETWS Primary Notification to MS
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/#/c/15459/3/src/gprs_ms.h 
File src/gprs_ms.h:

https://gerrit.osmocom.org/#/c/15459/3/src/gprs_ms.h@43 
PS3, Line 43: struct gprs_rlcmac_ms {
            : 	bool app_info_send;
            : };
> > why an extra struct around a single member? […]
Quick break down of the possibilities; I have no strong opinion on which one it *should* be, but here are the alternatives:

Using just a bool:
The simplest C way would be to add bool app_info_send as a public member field, so anyone can read and write directly, which is how we do it in pretty much every other osmocom code base.
The next simpler way would be to return a bool* in ms_data(), but I'd prefer getter/setter.

But if there will be more members in ms_data in the future, a struct is indeed a good choice.

Using a struct:
The simplest C way would be to have m_ms_data as a public compound member like:

    class GprsMs {
    public:
            struct {
                    bool app_info_send;
            } m_ms_data;
    };

The way this patch currently does it would be the choice if other code would re-use this struct (e.g. to store/pass-around all ms_data members in one, which seems a bit weird if there is only one member).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15459
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ie35959f833f46bde5f2126314b6f96763f863b36
Gerrit-Change-Number: 15459
Gerrit-PatchSet: 4
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Sep 2019 12:43:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at gnumonks.org>
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190911/54560e26/attachment.htm>


More information about the gerrit-log mailing list