This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/15432 ) Change subject: Add support for automatic card handling ...................................................................... Patch Set 3: Code-Review-1 (5 comments) https://gerrit.osmocom.org/#/c/15432/3/pySim-prog.py File pySim-prog.py: https://gerrit.osmocom.org/#/c/15432/3/pySim-prog.py@625 PS3, Line 625: first = False This is redundant as you change first at the end of the loop in line 753. The change here has no effect https://gerrit.osmocom.org/#/c/15432/3/pySim-prog.py@653 PS3, Line 653: card_handler.get(first) First will always be False here (I know, this was true before your patch as well, just became more visible with the refactoring) https://gerrit.osmocom.org/#/c/15432/3/pySim-prog.py@659 PS3, Line 659: card_handler.get(first) Same. First will always be False here https://gerrit.osmocom.org/#/c/15432/3/pySim-prog.py@673 PS3, Line 673: if opts.dry_run is not True: Sorry, nothing you introduced, but this looks really weird and redundant. I hope opts.dry_run hasn't change from line 670 to here. If it was False there it can't be True here. https://gerrit.osmocom.org/#/c/15432/3/pySim/card_handler.py File pySim/card_handler.py: https://gerrit.osmocom.org/#/c/15432/3/pySim/card_handler.py@94 PS3, Line 94: os._exit(rc) Is there a reason you are using os._exit() instead of sys.exit()? Unless you really need the properties of os._exit() (not flushing stdio, no cleanup) sys.exit() is probably the better choice. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/15432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icfed3cad7927b92816723d75603b78e1a4b87ef1 Gerrit-Change-Number: 15432 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-Comment-Date: Mon, 09 Sep 2019 08:47:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190909/ea04db0d/attachment.htm>