Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: initial version of component RAW_PCU_BTS_CT

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Sep 7 13:23:19 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15430 )

Change subject: PCU_Tests_RAW.ttcn: initial version of component RAW_PCU_BTS_CT
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/15430/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/#/c/15430/1//COMMIT_MSG@26 
PS1, Line 26: TDMA clock timer generates tons of logging messages, so
            :     we probably want to move it into a separate component.
> yes, it should be a separate component. And the . […]
Done in the next patch version.


https://gerrit.osmocom.org/#/c/15430/1/pcu/PCU_Tests_RAW.ttcn 
File pcu/PCU_Tests_RAW.ttcn:

https://gerrit.osmocom.org/#/c/15430/1/pcu/PCU_Tests_RAW.ttcn@515 
PS1, Line 515: FIXME: make sure to use parameters from mp_gb_cfg.cell_id
> this should be fixed, I guess?
Most likely in a separate change, not that critical for now.


https://gerrit.osmocom.org/#/c/15430/1/pcu/PCU_Tests_RAW.ttcn@552 
PS1, Line 552: tuwat
> Maybe give it a more descriptive name like "selftest"? ;)
This testcase is just for demo purposes, I will remove it in the end :)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15430
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I63a23abebab88fd5318eb4d907d6028e7c38e9a3
Gerrit-Change-Number: 15430
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Sat, 07 Sep 2019 13:23:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at gnumonks.org>
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190907/9e2c4554/attachment.htm>


More information about the gerrit-log mailing list