Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: fix: do not reset ECU with BFI frame

[fixeria]

Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-bts/+/15441

to look at the new patch set (#2).

Change subject: osmo-bts-trx/scheduler: fix: do not reset ECU with BFI frame
......................................................................

osmo-bts-trx/scheduler: fix: do not reset ECU with BFI frame

BFI (Bad Frame Indication) needs to be sent:

  - when failed to decode a speech (or FACCH) frame, or
  - when decoded frame is FACCH frame (23 octets long),

if the current channel mode is RSL_CMOD_SPD_SPEECH.

Since we (re)use the same buffer as used for non-BFI frames,
we need to avoid resetting the ECU (Error Cancellation Unit)
with a bad frame indication.

We used a boolean flag for that, but it was not set in the
second case - when a FACCH frame is decoded. Let's get rid
of that flag and use 'goto' operator to step over the ECU
resetting code.

Let's also modify rx_tchh_fn(), which does not (yet) deal
with ECU, but most likely will in the future.

Change-Id: I8bdc7483f524006a86ff1fee7cdefafe3db899d8
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 7 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/41/15441/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15441
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I8bdc7483f524006a86ff1fee7cdefafe3db899d8
Gerrit-Change-Number: 15441
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190907/d43fe619/attachment.htm>