This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15436 ) Change subject: Transceiver: Don't stop TRX if pulling from OFF timeslot ...................................................................... Patch Set 1: Code-Review-1 (4 comments) https://gerrit.osmocom.org/#/c/15436/1/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/#/c/15436/1/Transceiver52M/Transceiver.cpp@a613 PS1, Line 613: No need to move this line, just leave it here. https://gerrit.osmocom.org/#/c/15436/1/Transceiver52M/Transceiver.cpp@a618 PS1, Line 618: Huh, looks like a bug to me: bi->tn is not (yet) assigned at this point. Not sure why are you moving this block as a part of this change, but I would prefer to see the fix in a separate change. A simple solution is to assign fi->fn and bi->tn just before this block. https://gerrit.osmocom.org/#/c/15436/1/Transceiver52M/Transceiver.cpp@591 PS1, Line 591: -1: timeslot is off (fn and tn in bi are filled), You could use the macros from errno.h here: -1: ENODATA, ENODEV, ENOENT, or ENOMSG; -2: EIO; so the would be no need to explain their meaning. Just an idea, not a merge blocker. https://gerrit.osmocom.org/#/c/15436/1/Transceiver52M/Transceiver.cpp@1042 PS1, Line 1042: NOTICE This looks like a normal event to me when one or more timeslots are disabled. Not sure if we should log anything at all... -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15436 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Icf62e5d1200c7a440f255bb46023cdbf61532b7f Gerrit-Change-Number: 15436 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 06 Sep 2019 19:36:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190906/dbb4ef4c/attachment.htm>