Change in ...osmo-bsc[master]: bsc: gsm_08_08.c: Remove repeated conn not null check

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Sep 4 19:11:42 UTC 2019


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15407


Change subject: bsc: gsm_08_08.c: Remove repeated conn not null check
......................................................................

bsc: gsm_08_08.c: Remove repeated conn not null check

msc_is_connected() already checks against NULL.

Change-Id: Ie9635cd2c6149cd0f8c017cfcb47481f91c4bed1
---
M src/osmo-bsc/gsm_08_08.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/07/15407/1

diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c
index 43117a8..4b0752f 100644
--- a/src/osmo-bsc/gsm_08_08.c
+++ b/src/osmo-bsc/gsm_08_08.c
@@ -128,7 +128,7 @@
 	int rc;
 	struct msgb *resp;
 
-	if (!conn || !msc_connected(conn))
+	if (!msc_connected(conn))
 		return;
 
 	LOGP(DMSC, LOGL_NOTICE, "Tx MSC SAPI N REJECT DLCI=0x%02x\n", dlci);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15407
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie9635cd2c6149cd0f8c017cfcb47481f91c4bed1
Gerrit-Change-Number: 15407
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190904/8a7a85a0/attachment.htm>


More information about the gerrit-log mailing list