Change in ...osmo-iuh[master]: iu_client: introduce ranap_iu_free_ue() to free the UE connections

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Sep 3 15:33:32 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15161 )

Change subject: iu_client: introduce ranap_iu_free_ue() to free the UE connections
......................................................................


Patch Set 8: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/15161/8/src/iu_client.c 
File src/iu_client.c:

https://gerrit.osmocom.org/#/c/15161/8/src/iu_client.c@139 
PS8, Line 139: 	osmo_sccp_tx_disconn(g_scu, ue_ctx->conn_id, NULL, 0);
I don't really like the idea of calling tx_disconn inside free() function, imho tx_disconn should be called by the user if possible before calling free()


https://gerrit.osmocom.org/#/c/15161/8/src/iu_client.c@816 
PS8, Line 816: 		/* A Iu Release event might be used to free the UE in cn_ranap_handle_co. */
This seems not related to the patch?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15161
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I6812edb4da487507ccf9f483de801c1c65c4b72b
Gerrit-Change-Number: 15161
Gerrit-PatchSet: 8
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 03 Sep 2019 15:33:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190903/57aa6a94/attachment.htm>


More information about the gerrit-log mailing list