Change in ...libosmo-abis[master]: ipa: ipa_server_link_close() add checks of link state

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Sep 3 09:00:16 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/15387 )

Change subject: ipa: ipa_server_link_close() add checks of link state
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/15387/1/src/input/ipa.c 
File src/input/ipa.c:

https://gerrit.osmocom.org/#/c/15387/1/src/input/ipa.c@336 
PS1, Line 336: 	if (osmo_fd_is_registered(&link->ofd))
There was recently a discussion about similar patch, Better make sure ofd.fd is initialized to -1 and simply use (link->ofd.fd < 0) condition for both lines.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/15387
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I672d4de25464c3829b08aff26b1a6d4ad92e7684
Gerrit-Change-Number: 15387
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 03 Sep 2019 09:00:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190903/8d5cc3b8/attachment.htm>


More information about the gerrit-log mailing list