This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15361 )
Change subject: Move out gbproxy to its own subdir
......................................................................
Patch Set 2:
(1 comment)
It looks strange that you're introducing a static library, but in the end nobody will link against it o_O. Maybe I am missing something...
https://gerrit.osmocom.org/#/c/15361/2/src/gbproxy/Makefile.am
File src/gbproxy/Makefile.am:
https://gerrit.osmocom.org/#/c/15361/2/src/gbproxy/Makefile.am@35
PS2, Line 35: $(top_builddir)/src/gprs/gprs_gb_parse.o \
: $(top_builddir)/src/gprs/gprs_llc_parse.o \
: $(top_builddir)/src/gprs/crc24.o \
: $(top_builddir)/src/gprs/gprs_utils.o \
Can we just link against 'libcommon.la' here? If no, please describe why in the comment message.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15361
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I2cc98d3a276d953609bbbbaa9782a0112687791e
Gerrit-Change-Number: 15361
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 02 Sep 2019 12:07:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190902/d6b32310/attachment.htm>