This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15307 ) Change subject: Introduce log helper LOGGGSN and log category DGTP ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/#/c/15307/2/include/osmocom/sgsn/gprs_sgsn.h File include/osmocom/sgsn/gprs_sgsn.h: https://gerrit.osmocom.org/#/c/15307/2/include/osmocom/sgsn/gprs_sgsn.h@410 PS2, Line 410: INET_ADDRSTRLEN > What about '\0'? As far as I can see, other code parts are using INET_ADDRSTRLEN + 1, while in libos […] "man inet_ntop": "The buffer dst must be at least INET_ADDRSTRLEN bytes long." /usr/include/netinet/in.h 232:#define INET_ADDRSTRLEN 16 xxx.xxx.xxx.xxx = 3*4 + 3 = 15 So \0 is accounted in the define. https://gerrit.osmocom.org/#/c/15307/2/include/osmocom/sgsn/gprs_sgsn.h@411 PS2, Line 411: &(ggc)->remote_addr > So this address is always IPv4, right? So far yes, remot_addr is an in_addr. We can imporve this later if/when we add ipv6 support. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I30f46f44af1d0eee324b1a995c1dad2e1315af7c Gerrit-Change-Number: 15307 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Mon, 02 Sep 2019 08:30:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <axilirator at gmail.com> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190902/ed2fc73c/attachment.htm>