This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15916 ) Change subject: add osmo_gsup_conn_send_err_reply() ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/osmo-hlr/+/15916/2/src/gsup_server.c File src/gsup_server.c: https://gerrit.osmocom.org/c/osmo-hlr/+/15916/2/src/gsup_server.c@66 PS2, Line 66: only REQUESTs need an error reply Probably, makes sense to print a warning then. https://gerrit.osmocom.org/c/osmo-hlr/+/15916/2/src/gsup_server.c@88 PS2, Line 88: OSMO_ASSERT osmo_gsup_msgb_alloc() also assert()s the result of allocation, so this is redundant. https://gerrit.osmocom.org/c/osmo-hlr/+/15916/2/src/gsup_server.c@89 PS2, Line 89: osmo_gsup_encode Should we check if encoding failed? -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/15916 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I792fd9993ab2a323af58782a357d71205c43b72a Gerrit-Change-Number: 15916 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Thu, 31 Oct 2019 18:42:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191031/36334358/attachment.htm>