Change in osmo-hlr[master]: fix upgrade to version 2: imei column default value

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Oct 31 18:23:52 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15911 )

Change subject: fix upgrade to version 2: imei column default value
......................................................................


Patch Set 1:

(1 comment)

Adding Oliver, as he is the author of the related code (to my best knowledge).

https://gerrit.osmocom.org/c/osmo-hlr/+/15911/1/src/db.c 
File src/db.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/15911/1/src/db.c@a302 
PS1, Line 302: default NULL
Shouldn't IMEI actually be NULL by default? AFAIK, storing IMEI(SV) is an optional feature, so what if this is exactly the correct behaviour, and we also need to add this statement to 'stmt_bootstrap_sql'?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/15911
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I68a00014a3d603fcba8781470bc5285f78b538d0
Gerrit-Change-Number: 15911
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 31 Oct 2019 18:23:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191031/5611f3a8/attachment.htm>


More information about the gerrit-log mailing list