Change in osmo-hlr[master]: hlr db schema 3: hlr_number -> msc_number

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Thu Oct 31 16:53:23 UTC 2019


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-hlr/+/15914

to look at the new patch set (#2).

Change subject: hlr db schema 3: hlr_number -> msc_number
......................................................................

hlr db schema 3: hlr_number -> msc_number

The osmo-hlr DB schema indicates a hlr_number column and references it as 3GPP
TS 23.008 chapter 2.4.6. However, chapter 2.4.6 refers to the "MSC number",
while the "HLR number" is chapter 2.4.7.

Taking a closer look, 2.4.6 says "The MSC number is [...] stored in the HLR",
while 2.4.7 says "The HLR number may be stored in the VLR". As quite obvious,
the HLR does not store the HLR number. This was a typo from the start.

The osmo-hlr code base so far does not use the hlr_number column at all, so we
get away with renaming the column without any effects on the code base.
However, let's rather make this a new schema version to be safe.

Change-Id: I527e8627b24b79f3e9eec32675c7f5a3a6d25440
---
M doc/manuals/chapters/subscribers.adoc
M sql/hlr.sql
M src/db.c
M tests/db_upgrade/db_upgrade_test.ok
4 files changed, 57 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/14/15914/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/15914
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I527e8627b24b79f3e9eec32675c7f5a3a6d25440
Gerrit-Change-Number: 15914
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191031/23ee2bf5/attachment.htm>


More information about the gerrit-log mailing list