Change in osmo-bts[master]: rsl: Always enable MS Power Ctrl loop in BTS to keep compatibility wi...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Oct 30 12:42:02 UTC 2019


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15906 )


Change subject: rsl: Always enable MS Power Ctrl loop in BTS to keep compatibility with old osmo-bsc
......................................................................

rsl: Always enable MS Power Ctrl loop in BTS to keep compatibility with old osmo-bsc

There's no need to enable it always in RSL MS Power Control message,
because old osmo-bsc doesn't send it anyway, so in there we can keep the
correct behavior for other BSCs.

Related: OS#1622
Change-Id: I2b4660aa06ffb10694448697aa4b8e460e4bb206
---
M src/common/rsl.c
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/06/15906/1

diff --git a/src/common/rsl.c b/src/common/rsl.c
index de51e6f..922e666 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -1170,6 +1170,11 @@
 		* autonomous MS power control loop in BTS if 'MS Power
 		* Parameters' IE is present! */
 		lchan->ms_power_ctrl.fixed = 1;
+		/* ...however, since osmo-bsc until recently was not sending this
+		   IE, let's always enable autonomous MS power control loop in
+		   BTS anyway in order to avoid compat breakage against recent old
+		   versions of osmo-bsc. Let's keep it this way for a while. */
+		lchan->ms_power_ctrl.fixed = 0;
 	}
 	/* 9.3.16 Physical Context */
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15906
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I2b4660aa06ffb10694448697aa4b8e460e4bb206
Gerrit-Change-Number: 15906
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191030/8eac98be/attachment.htm>


More information about the gerrit-log mailing list