Change in libosmocore[master]: fsm_dealloc_test: enable term_stops_actions

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Tue Oct 29 16:20:15 UTC 2019


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15834 )

Change subject: fsm_dealloc_test: enable term_stops_actions
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/15834/1/tests/fsm/fsm_dealloc_test.c 
File tests/fsm/fsm_dealloc_test.c:

https://gerrit.osmocom.org/c/libosmocore/+/15834/1/tests/fsm/fsm_dealloc_test.c@457 
PS1, Line 457: osmo_fsm_set_term_stops_actions
> So now you're testing the new behaviour only?
I'm just making the logs a bit shorter...
I think osmo_fsm_set_term_stops_actions(true) is the only case we should care about, really.
I'd make it the unconfigurable default if that is ok with backwards compatibility.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15834
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iff7843e12ce49f169f8c36b14fdb19935f61274d
Gerrit-Change-Number: 15834
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 29 Oct 2019 16:20:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191029/2f92c145/attachment.htm>


More information about the gerrit-log mailing list