This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15847 ) Change subject: log: RANAP encode: use RANAP message names instead of BSSAP ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/15847/1/src/libmsc/ran_msg_iu.c File src/libmsc/ran_msg_iu.c: https://gerrit.osmocom.org/c/osmo-msc/+/15847/1/src/libmsc/ran_msg_iu.c@402 PS1, Line 402: LOG_RAN_IU_ENC(caller_fi, LOGL_DEBUG, "DirectTransfer\n"); > Can we then at least use Can we then use strings from value_string directly so we don't duplicate st […] These are the only instances of these RANAP specific strings, there are no dups. (The messages' names differ between RANAP and BSSMAP, using ran_msg_type_names[] would give me the BSSMAP names, but I want the RANAP names. Since BSSMAP is the "usual" mode of operation for osmo-msc, I decided to use the BSSMAP naming for the internal structures and RAN message types, but in practice these are RAN independent. Only the ran_msg_a.c and ran_msg_iu.c make the distinction between BSSMAP and RANAP encoding, so these places here where the string constants are added should be the exact only places where we want to name the individual messages according to RANAP.) I humbly think this is a sub-tiny aspect of the upcoming patches and not worth it to discuss at length... If this is still controversial, I would rather consider dropping the patch than spending more time. I would rather get on to the interesting patches, where I really fundamentally change the way osmo-msc works ... if you allow, of course -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15847 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib0e0630d775a28958ea86802f70cbeec07087f91 Gerrit-Change-Number: 15847 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 29 Oct 2019 15:44:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de> Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191029/679201b5/attachment.htm>