Change in osmo-msc[master]: msc_vty: no warning for ignored "cs7-instance-iu"

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Oct 29 14:15:02 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15894 )

Change subject: msc_vty: no warning for ignored "cs7-instance-iu"
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-msc/+/15894/1/src/libmsc/msc_vty.c 
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/c/osmo-msc/+/15894/1/src/libmsc/msc_vty.c@506 
PS1, Line 506: 	/* Return CMD_SUCCESS anyway, so we can use the same config. */
I don't think this is the correct fix here. Rather fix tests to use different cfg files or split some tests to be run only if confiure sets BUILD_IU or similar.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15894
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8889c21307257e7c32d0c3f9dcafb617c1b05efd
Gerrit-Change-Number: 15894
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 29 Oct 2019 14:15:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191029/c1081327/attachment.htm>


More information about the gerrit-log mailing list