Change in osmo-msc[master]: msc_vty: no warning for ignored "cs7-instance-iu"

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Tue Oct 29 14:08:22 UTC 2019


osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/15894 )


Change subject: msc_vty: no warning for ignored "cs7-instance-iu"
......................................................................

msc_vty: no warning for ignored "cs7-instance-iu"

Do not return a warning and therefore fail parsing the config when
"cs7-instance-iu" is used and IU is disabled. This fixes the vty tests,
which are failing since libosmocore change
Ic225232fbfca49ba868427eaf898e1f6e34e1ca8.

Change-Id: I8889c21307257e7c32d0c3f9dcafb617c1b05efd
---
M src/libmsc/msc_vty.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/94/15894/1

diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c
index 51504ef..dc170d3 100644
--- a/src/libmsc/msc_vty.c
+++ b/src/libmsc/msc_vty.c
@@ -500,12 +500,12 @@
 {
 #if BUILD_IU
 	gsmnet->iu.cs7_instance = atoi(argv[0]);
-	return CMD_SUCCESS;
 #else
 	vty_out(vty, "WARNING: 'cs7-instance-iu' without effect: built without Iu support%s",
 		VTY_NEWLINE);
-	return CMD_WARNING;
+	/* Return CMD_SUCCESS anyway, so we can use the same config. */
 #endif
+	return CMD_SUCCESS;
 }
 
 DEFUN(cfg_msc_auth_tuple_max_reuse_count, cfg_msc_auth_tuple_max_reuse_count_cmd,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15894
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8889c21307257e7c32d0c3f9dcafb617c1b05efd
Gerrit-Change-Number: 15894
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191029/ae5b2ca3/attachment.htm>


More information about the gerrit-log mailing list