Change in osmo-sgsn[master]: osmo-gbproxy.cfg: remove framerelay-gre

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Oct 29 11:15:27 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15887 )

Change subject: osmo-gbproxy.cfg: remove framerelay-gre
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-sgsn/+/15887/1/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg 
File doc/examples/osmo-gbproxy/osmo-gbproxy.cfg:

https://gerrit.osmocom.org/c/osmo-sgsn/+/15887/1/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg@a23 
PS1, Line 23:  encapsulation framerelay-gre enabled 0
> It seems like it, but it will fail unless both lines are removed.
But then it fails somehow later? I don't understand, because the first removed cmd cannot fail with a warning:
"""
DEFUN(cfg_frgre_enable, cfg_frgre_enable_cmd,
      "encapsulation framerelay-gre enabled (1|0)",
	ENCAPS_STR "NS over Frame Relay over GRE Encapsulation\n"
	"Enable or disable Frame Relay over GRE\n"
	"Enable\n" "Disable\n")
{
	int enabled = atoi(argv[0]);

	vty_nsi->frgre.enabled = enabled;

	return CMD_SUCCESS;
}
"""


While the second indeed does print the warning you see:
"""
DEFUN(cfg_frgre_local_ip, cfg_frgre_local_ip_cmd,
      "encapsulation framerelay-gre local-ip A.B.C.D",
	ENCAPS_STR "NS over Frame Relay over GRE Encapsulation\n"
	"Set the IP address on which we listen for NS/FR/GRE\n"
	"IP Address\n")
{
	struct in_addr ia;

	if (!vty_nsi->frgre.enabled) {
		vty_out(vty, "FR/GRE is not enabled%s", VTY_NEWLINE);
		return CMD_WARNING;
	}
	inet_aton(argv[0], &ia);
	vty_nsi->frgre.local_ip = osmo_ntohl(ia.s_addr);

	return CMD_SUCCESS;
}
"""



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15887
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ibbb2fb80540ba78cded99ced1926e523d529dc35
Gerrit-Change-Number: 15887
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 29 Oct 2019 11:15:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191029/cc485c4d/attachment.htm>


More information about the gerrit-log mailing list