Change in osmo-bts[master]: power_control.c: Take into account RSL CHAN ACT ms power level limits

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Oct 28 16:01:31 UTC 2019


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15884 )


Change subject: power_control.c: Take into account RSL CHAN ACT ms power level limits
......................................................................

power_control.c: Take into account RSL CHAN ACT ms power level limits

This is similar commit to Ifda92155bd9c277ac150a327a7ab63c854087788,
which previously fixed same issue for osmo-bts-trx specific power
control loop code.

TS 48.058 sec 4.8 MS power control:
"""
TRX then attempts to keep the power control parameters within the limits
set by the MS POWER CONTROL message (or by the CHANNEL ACTIVATION message)
by changing the MS Power Level field of the L1 header sent to MS in each
SACCH block.
"""

Should fix TTCN3 BTS_Tests.TC_rsl_ms_pwr_dyn_max for non-bts-trx BTS
models.

Related: OS#1622
Change-Id: I376b52d7bee44132993a69cf532bd418171d0ca2
---
M src/common/power_control.c
1 file changed, 7 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/84/15884/1

diff --git a/src/common/power_control.c b/src/common/power_control.c
index b172870..f467cd5 100644
--- a/src/common/power_control.c
+++ b/src/common/power_control.c
@@ -79,6 +79,13 @@
 	}
 
 	new_pwr = ms_pwr_ctl_lvl(band, new_dBm);
+
+	/* Don't ask for smaller ms power level than the one set
+	 * by BSC upon RSL CHAN ACT
+	 */
+	if (new_pwr < lchan->ms_power)
+		new_pwr = lchan->ms_power;
+
 	if (lchan->ms_power_ctrl.current != new_pwr) {
 		lchan->ms_power_ctrl.current = new_pwr;
 		bts_model_adjst_ms_pwr(lchan);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15884
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I376b52d7bee44132993a69cf532bd418171d0ca2
Gerrit-Change-Number: 15884
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191028/06c1a623/attachment.htm>


More information about the gerrit-log mailing list