Change in libosmo-sccp[master]: ss7: Set Traffic mode and Route Ctx in ASPAC ACK msg if known

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15862 )

Change subject: ss7: Set Traffic mode and Route Ctx in ASPAC ACK msg if known
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmo-sccp/+/15862/1/src/xua_asp_fsm.c 
File src/xua_asp_fsm.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/15862/1/src/xua_asp_fsm.c@241 
PS1, Line 241: 		if (rctx_cnt) {
             : 			as = osmo_ss7_as_find_by_rctx(asp->inst, rctxs[0]);
             : 			tmode = osmo_ss7_tmode_to_xua(as->cfg.mode);
             : 			if (as && tmode != -1)
             : 				xua_msg_add_u32(xua, SUA_IEI_TRAF_MODE_TYP, tmode);
             : 		}
             : 		/* Optional: Routing Context */
I think the condition whether or not to add these here is whether or not they were present in the ASPAC.  This may not be the same as us having routing contexts configured in the AS object.  I don't have a clear plan what to do, I'm just pointing out what I see as a possible inconsistency.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15862
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ic99131489efaef87f882312a042f5feb6a60bb86
Gerrit-Change-Number: 15862
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 23 Oct 2019 21:36:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191023/4a5db746/attachment.htm>