This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15757 ) Change subject: scheduler_trx: use gsm0502_fn_remap() to calculate frame number ...................................................................... Patch Set 3: (4 comments) This change is ready for review. https://gerrit.osmocom.org/c/osmo-bts/+/15757/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/c/osmo-bts/+/15757/1/src/osmo-bts-trx/scheduler_trx.c@1230 PS1, Line 1230: FN_REMAP_FACCH_F > You can't be sure at this point as you don't know whether it's FACCH or speech. I noticed the problem. I have now moved the l1if_process_meas_res function call to the positions where the payload indication is generated. This is moving us also closer to the next task where we will merge the measurement data into the payload indication. I am not sure if it is correct now, but I am not sure what happens if the the frame gets stolen by FACCH, maybe we are calling l1if_process_meas_res now two times, once for the FAACH and once for the stolen frame that isn't actually there? I think that if this gets to complicated to resolve, we should consider to do this in a separate patch. https://gerrit.osmocom.org/c/osmo-bts/+/15757/1/src/osmo-bts-trx/scheduler_trx.c@1318 PS1, Line 1318: FN_REMAP_FACCH_F > That's actually not FACCH. Done https://gerrit.osmocom.org/c/osmo-bts/+/15757/1/src/osmo-bts-trx/scheduler_trx.c@1442 PS1, Line 1442: FN_REMAP_TCH_H0 > Same here, what if the received frame is FACCH/H? (see above) https://gerrit.osmocom.org/c/osmo-bts/+/15757/1/src/osmo-bts-trx/scheduler_trx.c@1473 PS1, Line 1473: FN_REMAP_FACCH_H0 > Can be simplified: FN_REMAP_FACCH_H0 + lchan->nr. I don't think that it is a good idea to add values to an enum, we should keep it like it is to be more explicit. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15757 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I37601ddd85e4287dd9e41ad4a8cb7d314de1a83d Gerrit-Change-Number: 15757 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Tue, 22 Oct 2019 13:56:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <axilirator at gmail.com> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191022/fbfdd213/attachment.htm>