Change in libosmo-sccp[master]: cosmetic: Document why IPA uses hard-coded routing-context 0

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Oct 21 11:21:29 UTC 2019


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15816 )

Change subject: cosmetic: Document why IPA uses hard-coded routing-context 0
......................................................................

cosmetic: Document why IPA uses hard-coded routing-context 0

Change-Id: Ibfae10a1e9385079db4b353e48a262bc8ab5230a
---
M src/xua_asp_fsm.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c
index 9dc9a82..c5bd116 100644
--- a/src/xua_asp_fsm.c
+++ b/src/xua_asp_fsm.c
@@ -848,6 +848,7 @@
 	struct ipa_asp_fsm_priv *iafp = fi->priv;
 	struct osmo_ss7_asp *asp = iafp->asp;
 	struct osmo_ss7_instance *inst = asp->inst;
+	/* We use routing-context '0' here, as that's the only one we support in IPA */
 	struct osmo_ss7_as *as = osmo_ss7_as_find_by_rctx(inst, 0);
 
 	OSMO_ASSERT(as);
@@ -920,6 +921,7 @@
 {
 	struct osmo_ss7_asp *asp = iafp->asp;
 	struct osmo_ss7_instance *inst = asp->inst;
+	/* We use routing-context '0' here, as that's the only one we support in IPA */
 	struct osmo_ss7_as *as = osmo_ss7_as_find_by_rctx(inst, 0);
 	struct osmo_ss7_route *rt;
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15816
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ibfae10a1e9385079db4b353e48a262bc8ab5230a
Gerrit-Change-Number: 15816
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191021/ead731ff/attachment.htm>


More information about the gerrit-log mailing list