Change in osmo-bts[master]: vty.c: don't ignore get_string_value() errors

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Mon Oct 21 09:10:03 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15805 )

Change subject: vty.c: don't ignore get_string_value() errors
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/15805/2/src/common/vty.c 
File src/common/vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/15805/2/src/common/vty.c@1606 
PS2, Line 1606: 	int8_t sapi = get_string_value(l1sap_common_sapi_names, argv[0]);
> I'd rather let sapi be an int, it's not entirely clear to me how the cast from int to int8_t is bein […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15805
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4d30afacfab93051868ae8f462cee9ad3dbc7fd0
Gerrit-Change-Number: 15805
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 21 Oct 2019 09:10:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191021/14d6a7fe/attachment.htm>


More information about the gerrit-log mailing list